Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.Mako: cleanup & enable PyPy tests #98393

Merged
merged 2 commits into from Sep 22, 2020
Merged

pythonPackages.Mako: cleanup & enable PyPy tests #98393

merged 2 commits into from Sep 22, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

While fixing #98391, found some out of date things in pythonPackages.Mako.

  • Cleaned up meta
  • Enabled more tests
  • Updated issue links to new non-BitBucket location.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
pythonPackages.Mako: cleanup meta
80b5836 
* Update homepage to HTTPS
* Add changelog
@drewrisinger
pythonPackages.Mako: convert to pytestCheckHook
ec3b5f9 
* Expands testing by disabling only known failing tests on pypy.
* Update issue links to GitHub repo.
@drewrisinger drewrisinger marked this pull request as draft September 21, 2020 13:38
@drewrisinger drewrisinger changed the base branch from master to staging September 21, 2020 13:38
@drewrisinger drewrisinger marked this pull request as ready for review September 21, 2020 13:45
@drewrisinger drewrisinger changed the title pythonPackages.Mako: cleanup & enable tests pythonPackages.Mako: cleanup & enable PyPy tests Sep 21, 2020
@ofborg ofborg bot requested a review from domenkozar September 21, 2020 14:05
@mweinelt
Copy link
Member

Fails on pypy2.7, maybe disable?

=================================== FAILURES ===================================
____________________ EncodingTest.test_bytestring_passthru _____________________
Traceback (most recent call last):
  File "/build/Mako-1.1.3/test/test_template.py", line 603, in test_bytestring_passthru
    self.assertRaises(UnicodeDecodeError, template.render)
  File "/nix/store/idb40rk8awki0mjjsd2amdj3q1biiwm6-pypy-7.3.1/pypy-c/lib-python/2.7/unittest/case.py", line 473, in assertRaises
    callableObj(*args, **kwargs)
  File "/nix/store/idb40rk8awki0mjjsd2amdj3q1biiwm6-pypy-7.3.1/pypy-c/lib-python/2.7/unittest/case.py", line 116, in __exit__
    "{0} not raised".format(exc_name))
AssertionError: UnicodeDecodeError not raised
=========================== short test summary info ============================
FAILED test/test_template.py::EncodingTest::test_bytestring_passthru - Assert...
======= 1 failed, 406 passed, 59 skipped, 3 deselected in 11.77 seconds ========
builder for '/nix/store/3hvxvax9kf8i24bjs1f8hg1mbzg86760-pypy2.7-Mako-1.1.3.drv' failed with exit code 1

@jonringer
Copy link
Contributor

@GrahamcOfBorg build azure-cli
@GrahamcOfBorg build python2Packages.Mako
@GrahamcOfBorg build python3Packages.Mako
@GrahamcOfBorg build python37Packages.Mako

@drewrisinger
Copy link
Contributor Author

Thanks @mweinelt, didn't find that in my spot check. Fixed & pushed.

@jonringer
Copy link
Contributor

@GrahamcOfBorg build azure-cli
@GrahamcOfBorg build python2Packages.Mako
@GrahamcOfBorg build python3Packages.Mako
@GrahamcOfBorg build python37Packages.Mako

jonringer
jonringer approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[09:05:44] jon@nixos ~/projects/nixpkgs (dr-pr-mako-cleanup)
$ nbfkg azure-cli python3Packages.Mako python37Packages.Mako python2Packages.Mako
[1 built, 0.0 MiB DL]

@jonringer jonringer merged commit c24b933 into NixOS:staging Sep 22, 2020
@drewrisinger drewrisinger deleted the dr-pr-mako-cleanup branch September 22, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drewrisinger @mweinelt @jonringer