Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pecan: 1.3.3 -> 1.4.0, fix build; pythonPackages.WSME: fix build #98391

Merged
merged 2 commits into from Sep 21, 2020
Merged

pythonPackages.pecan: 1.3.3 -> 1.4.0, fix build; pythonPackages.WSME: fix build #98391

merged 2 commits into from Sep 21, 2020

Conversation

drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Sep 21, 2020 •
edited

Motivation for this change

While reviewing #98151, noticed this package was broken. Found out the issue was the upstream pythonPackages.pecan not propagating python dependencies, so build would fail. Fixed both.

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
pythonPackages.pecan: 1.3.3 -> 1.4.0
fe5a336 
* Update Homepage
* Add Changelog
* Convert to pytestCheckHook
* Remove buildInputs, corrected to propagatedBuildInputs or checkInputs as appropriate.
  This caused downstream failures because some required packages were not in the runtime closure (PYTHONPATH).
@drewrisinger
pythonPackages.WSME: fix build
8b0cad4 
* Remove unneeded patch
* Run tests properly (misspelled before)
* Update homepage & add changelog
* Sort dependencies
@drewrisinger drewrisinger mentioned this pull request Sep 21, 2020
Merged
10 tasks
@drewrisinger drewrisinger marked this pull request as draft September 21, 2020 13:36
@drewrisinger drewrisinger force-pushed the zhf/python-wsme branch 2 times, most recently from f6adf4e to 8b0cad4 Compare September 21, 2020 16:10
@drewrisinger drewrisinger marked this pull request as ready for review September 21, 2020 16:24
jonringer
jonringer approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/98391
1 package failed to build:
bareos

8 packages built:
ceph ceph-client libceph python37Packages.WSME python37Packages.pecan python38Packages.WSME python38Packages.pecan samba4Full

@jonringer jonringer merged commit 143289a into NixOS:master Sep 21, 2020
@drewrisinger drewrisinger deleted the zhf/python-wsme branch September 21, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drewrisinger @jonringer