Fails to build on NixOS. This seems to be because one of the tests got split. I am currently testing this change:

-    "--skip=parse_correct_ips_or_hosts"
+    "--skip=parse_correct_host_addresses"

With the above changes, the package builds and runs fine on NixOS.

Changed.

I built it locally and nothing failed. Are the tests more strict on nixOS compared to nix? And why is graham green if the tests fail in nixOS? I am a bit confused right now. Can you maybe clear this up or reference some documentation about this?

Perhaps the sandbox is off by default on foreign distributions? Also, I had the impression that the CI hooked up to GitHub PRs only checks whether the derivations instantiate without errors...

Sandbox is disabled on Debian and Ubuntu because it sometimes causes really strange errors when building certain packages. Not ideal for package maintenance but I try to keep it in mind and maybe change that in the future.

@NieDzejkob Could you maybe take another look if it still builds/passes tests on nixOS? (I should setup some VM...)

you could also try enabling the sandbox in your configuration file on your machine. That should catch most issues ;)

Then some nodePackages are not building.

parse_correct_host_addresses still fails in 1.10.1 when sandboxed due to the network being unavailable. Your latest commit shouldn't be removing that skip flag.

I finally set up a Vagrant box to properly test with sandbox. 🎉