Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] tensorflow: Fix compilation with numpy 1.19.x #98373

Merged
merged 1 commit into from Sep 22, 2020
Merged

[20.09] tensorflow: Fix compilation with numpy 1.19.x #98373

merged 1 commit into from Sep 22, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Numpy introduced a breaking API change in version 1.19.x, see 1.

There is a simple fix 2 available in the master branch.

(cherry picked from commit 8f5bfd6)

ZHF #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@avdv @danieldk
tensorflow: Fix compilation with numpy 1.19.x
2adb029 
Numpy introduced a breaking API change in version 1.19.x, see [1].

There is a simple fix [2] available in the master branch.

[1]: tensorflow/tensorflow#40688
[2]: tensorflow/tensorflow@75ea0b3

(cherry picked from commit 8f5bfd6)
@danieldk
Copy link
Contributor Author

@ofborg build python37Packages.tensorflow

@ofborg ofborg bot requested a review from abbradar September 21, 2020 06:14
@avdv avdv mentioned this pull request Sep 21, 2020
Closed
10 tasks
@jonringer jonringer merged commit ba0bd29 into NixOS:release-20.09 Sep 22, 2020
@minsky-1
Copy link

Does this solution imply to uninstall numpy.1.19.1.x ?
Thanks for the reply...

@minsky-1
Copy link

And install numpy1.17.x?

@danieldk danieldk deleted the tensorflow1-backport-20.09 branch October 13, 2020 06:27
@danieldk
Copy link
Contributor Author

No, this change should make tensorflow compatible with 1.19.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danieldk @minsky-1 @jonringer @avdv