pythonPackages.mohawk: init at 1.1.0 #98336
Conversation
| description = "Python library for Hawk HTTP authorization."; | ||
| homepage = "https://github.com/kumar303/mohawk"; | ||
| license = licenses.mpl20; | ||
| maintainers = [ ]; |
There was a problem hiding this comment.
please add yourself as a maintainer :)
There was a problem hiding this comment.
I can do this, but just to be clear this PR is purely from ZHF, I don't use this package or Alerta. As I noted in the second paragraph I don't even know how to test importing this package currently.
There was a problem hiding this comment.
ah, then you can skip it... but it's just nice to have someone who has context
There was a problem hiding this comment.
Cool, I will skip for now. Any suggestions on the equivalent of python3 -c "import mohawk" but using mohawk from result? Best I've come up with is PYTHONPATH=result/lib/python3.8/site-packages:/nix/store/md9ld5w5s4dkqkm0rjbsqrlzlhyjiq4y-python3.8-six-1.15.0/lib/python3.8/site-packages python -c "import mohawk".
There was a problem hiding this comment.
pythonImportsCheck = [ "mohawk" ];
There was a problem hiding this comment.
If tests are not available, then please use pythonImportsCheck to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors. Please see pythonImportsCheck documentation for more information.
There was a problem hiding this comment.
That's helpful, although I more so mean an interactive Python REPL outside of the .nix file that can import from result. But I don't want this to turn into a support thread, and I think the PR is ready at this point.
There was a problem hiding this comment.
Any suggestions on the equivalent of
python3 -c "import mohawk"but using mohawk fromresult
nix-shell -I nixpkgs=$PWD -p python3Packages.mohawk --run "python -c 'import mohawk'"
austinbutler
force-pushed
the
mohawk
branch
from
6ae51cb
to
b072de4
Compare
Motivation for this change
This is actually part of getting the
alertaPython package fixed. My understanding from the 20.09 Hydra failure is that Alerta is failing becauserequests-hawkis not packaged. Andrequests-hawkneedsmohawk. So if this is correct my plan was to follow this PR up withrequests-hawk, then seeing if that fixes Alerta.This seems to pass all tests with all Python versions, however I am not sure how to actually try importing a Python package from
result, so I haven't tested this even imports. I guess I could temporarily put a command into the check phase that just tries to import it, but I was hoping someone had some guidance on the best practice for this.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)