Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmmlib: fix build #98335

Merged
merged 1 commit into from Sep 20, 2020
Merged

vmmlib: fix build #98335

merged 1 commit into from Sep 20, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 20, 2020

Motivation for this change

ZHF: #97479

Provide lapack instead of blas, causing gaussian elimination tests to no longer fail.

I've got to say, I have no ides why this fixes it. I don't understand blas/lapack at the best of times and its new alternatives system compounds my head-scratching.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
vmmlib: fix build
ef37712 
provide lapack instead of blas, causing gaussian elimination tests to
no longer fail

remove some trailing spaces from the longDescription to please the linter.
sorry.
@risicle
Copy link
Contributor Author

risicle commented Sep 20, 2020

...aaand I've also had to add about 5 lines of diff noise to please our linter that we now seem to have 🙄

@ofborg ofborg bot requested a review from adevress September 20, 2020 18:24
jonringer
jonringer approved these changes Sep 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 98335 1

1 package built:
  • vmmlib

@jonringer jonringer merged commit 5666056 into NixOS:master Sep 20, 2020
@risicle risicle mentioned this pull request Sep 20, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@adevress adevress Awaiting requested review from adevress

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @jonringer