prometheus: Unbreak IPv6 listenAddress #98349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The format of the listenAddress option was recently changed to separate the address and the port parts. There is now a legacy check that tells users to update to the new format. This legacy check produces a false positive on IPv6 addresses, since they contain colons. Fix the regex to make it not match colons within IPv6 addresses.
Closed
bjornfor
approved these changes
Sep 21, 2020
|
Thanks for the quick fix! I'm glad to see all hope is not lost with IPv6 yet 😅. |
|
Backported to release-20.09 as 3f5944e. |
jonringer
added
the
8.has: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for the IPv6-related issue reported by @lschuermann in #87700.