Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openblas: enable multiple outputs #98337

Merged
merged 1 commit into from Oct 5, 2020
Merged

openblas: enable multiple outputs #98337

merged 1 commit into from Oct 5, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 20, 2020 •
edited

Motivation for this change

noticed cmake and pkgconfig files were being propagated when reviewing #98335

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

modest closure decrease:

$ nix path-info -Sh ./result
/nix/store/9ygjz2yfbfizgs4i7qrz1ync14mfh7bf-openblas-0.3.10	  68.0M
# with changes
$ nix path-info -Sh ./result
/nix/store/v8slfaawv5bg40zf44ab9aqi54sr88p6-openblas-0.3.10	  66.6M

@jonringer jonringer changed the base branch from master to staging September 20, 2020 18:23
@jonringer
Copy link
Contributor Author

sorry for spam, had to rebase onto staging, 2600 packages were changed

@jonringer jonringer requested review from bhipple and removed request for edwtjo, cdepillabout, stigtsp, mmahut, andir, Ericson2314, nbp and zowoq September 20, 2020 18:24
@ofborg ofborg bot requested a review from ttuegel September 20, 2020 19:39
@jonringer
Copy link
Contributor Author

still "reviewing"

[64/5453/8228 built (98 failed), 2 copied (0.1/0.1 MiB), 0.1 MiB DL]

@jonringer
Copy link
Contributor Author

I didn't see any initial failures out of this, we can look at regressions on staging-next

@jonringer jonringer merged commit 7902256 into NixOS:staging Oct 5, 2020
markuskowa added a commit to markuskowa/nixpkgs that referenced this pull request Oct 19, 2020
@markuskowa
openmolcas: fix build w.r.t. openblas
8b02ff6 
Fall out from switching openblas over to multiple outputs:
NixOS#98337
markuskowa added a commit to Nix-QChem/NixOS-QChem that referenced this pull request Oct 19, 2020
@markuskowa
openmolcas: fix build w.r.t. openblas
4532d71 
Fall out from switching openblas over to multiple outputs:
NixOS/nixpkgs#98337
markuskowa added a commit to Nix-QChem/NixOS-QChem that referenced this pull request Oct 19, 2020
@markuskowa
openmolcas2010: fix build w.r.t. openblas
45e7edf 
Fall out from switching openblas over to multiple outputs:
NixOS/nixpkgs#98337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @bhipple