firefox-bin/update: fix #98338
Merged
firefox-bin/update: fix #98338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mozilla has ended the gpg.mozilla.org SKS server and the key can't be imported from keys.openpgp.org because it lacks a user ID because Mozilla hasn't verified their email... Since the key isn't going to change any time soon and SKS is mostly busted, might as well hard-code it.
|
EditorConfig check getting confused by the binary file :/ |
stigtsp
reviewed
Sep 22, 2020
There was a problem hiding this comment.
mozilla.asc in 2b44f56 matches:
pub rsa4096/61B7B526D98F0353 2015-07-17 [SC]
Key fingerprint = 14F2 6682 D091 6CDD 81E3 7B6D 61B7 B526 D98F 0353
uid [ unknown] Mozilla Software Releases <release@mozilla.com>
sub rsa4096/F1A6668FBB7D572E 2019-05-30 [S] [expires: 2021-05-29]
Btw, gpgv can use the keyring directly as long as its not armored.
$ gpg -o mozilla.gpg --dearmor mozilla.asc
$ gpgv --keyring=$(pwd)/mozilla.gpg SHA256SUMS.asc SHA256SUMS
gpgv: Signature made Mon 31 Aug 2020 10:59:13 PM CEST
gpgv: using RSA key 097B313077AE62A02F84DA4DF1A6668FBB7D572E
gpgv: Good signature from "Mozilla Software Releases <release@mozilla.com>"
|
/marvin opt-in |
|
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
stigtsp
approved these changes
Oct 24, 2020
taku0
approved these changes
Oct 24, 2020
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Oct 24, 2020
firefox-bin/update: fix (cherry picked from commit 7ecdf14)
|
I tried using this on Firefox but the upgrade script just block at some point and even after 20 minutes nothing happened. Does it work for anyone else on Firefox? |
taku0
added a commit
to taku0/nixpkgs
that referenced
this pull request
Oct 25, 2020
10 tasks
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Nov 9, 2020
NixOS#98338 (comment) (cherry picked from commit 4eacc37)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)