Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

softmaker-office: remove /bin/ls intercept #98413

Merged
merged 1 commit into from Sep 22, 2020
Merged

softmaker-office: remove /bin/ls intercept #98413

merged 1 commit into from Sep 22, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

This does not seem to be necessary anymore and fixes segmentation
faults on 20.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
softmaker-office: remove /bin/ls intercept
e883c65 
This does not seem to be necessary anymore and fixes segmentation
faults on 20.03.
@danieldk danieldk mentioned this pull request Sep 21, 2020
Closed
@InLaw
Copy link
Contributor

InLaw commented Sep 22, 2020

Result of nixpkgs-review pr 98413 1

2 packages built:
  • freeoffice
  • softmaker-office

@danieldk danieldk merged commit 260f03f into NixOS:master Sep 22, 2020
@InLaw
Copy link
Contributor

InLaw commented Sep 23, 2020

How do I know when it will be available in nixos-unstable?

  • current date is to old
nix-shell -p nix-prefetch-git  --run ' nix-prefetch-git https://github.com/nixos/nixpkgs-channels.git refs/heads/nixos-unstable '
{
  "url": "https://github.com/nixos/nixpkgs-channels.git",
  "rev": "1179840f9a88b8a548f4b11d1a03aa25a790c379",
  "date": "2020-09-19T20:38:05-07:00",
  "sha256": "00jy37wj04bvh299xgal2iik2my9l0nq6cw50r1b2kdfrji8d563",
  "fetchSubmodules": false
}

@danieldk
Copy link
Contributor Author

When the tests pass for nixos-unstable on Hydra and the channel moves forward again:

https://status.nixos.org/

nixos-unstable-small should already have the change.

@danieldk danieldk deleted the softmaker-remove-intercept branch September 23, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @InLaw