Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[haskell-updates] haskellPackages: Mark unbroken #98340

Merged

Conversation

Anton-Latukha
Copy link
Contributor

@Anton-Latukha Anton-Latukha commented Sep 20, 2020

  • summoner{,tui}
  • morley
  • lorentz
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member

Everything looks good here except that morte doesn't appear to compile:

$ git rev-parse HEAD # commit from this PR
195cd3297f2d1afbb89cca6cefc8e73cb3acf6a4
$ nix-build -A haskellPackages.morte --arg config '{allowBroken=true;}'
these derivations will be built:
  /nix/store/kay0q9wh6zfxlkpqydz8r9fyma3ak807-morte-1.7.2.drv
building '/nix/store/kay0q9wh6zfxlkpqydz8r9fyma3ak807-morte-1.7.2.drv'...
setupCompilerEnvironmentPhase
Build with /nix/store/w30rhw13ji6vkv0zksms5h7897cxvl90-ghc-8.8.4.
unpacking sources
unpacking source archive /nix/store/48qw8rlx8hj1agkq8xcw2gd6virs289j-morte-1.7.2.tar.gz
source root is morte-1.7.2
setting SOURCE_DATE_EPOCH to timestamp 1572822742 of file morte-1.7.2/test/src/example9.mt
patching sources
compileBuildDriverPhase
setupCompileFlags: -package-db=/build/setup-package.conf.d -j8 +RTS -A64M -RTS -threaded -rtsopts
[1 of 1] Compiling Main             ( Setup.hs, /build/Main.o )
Linking Setup ...
configuring
configureFlags: --verbose --prefix=/nix/store/ymsxdp1lpaymgzys238qq96mkczcig7b-morte-1.7.2 --libdir=$prefix/lib/$compiler --libsubdir=$abi/$libname --datadir=/nix/store/gqccm851xl308p10llnc9zdnswjmzclq-morte-1.7.2-data/share/ghc-8.8.4 --docdir=/nix/store/2ny24f47y6q3fr4p12yfdygx4pdn8rj1-morte-1.7.2-doc/share/doc/morte-1.7.2 --with-gcc=gcc --package-db=/build/package.conf.d --ghc-options=-j8 +RTS -A64M -RTS --disable-split-objs --enable-library-profiling --profiling-detail=exported-functions --disable-profiling --enable-shared --disable-coverage --enable-static --disable-executable-dynamic --enable-tests --disable-benchmarks --enable-library-vanilla --disable-library-for-ghci --ghc-option=-split-sections --extra-lib-dirs=/nix/store/pk73wc0x32y2bmbiqiddb084w398ab6y-ncurses-6.2/lib --extra-lib-dirs=/nix/store/s0mblhs5vmjza9dmipn74rwqflxy1fw7-libffi-3.3/lib --extra-lib-dirs=/nix/store/fphpbj8jpyibz0l2xspidg6s7zm7xyb5-gmp-6.2.0/lib
Using Parsec parser
Configuring morte-1.7.2...
CallStack (from HasCallStack):
  die', called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:1022:20 in Cabal-3.0.1.0:Distribution.Simple.Configure
  configureFinalizedPackage, called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:475:12 in Cabal-3.0.1.0:Distribution.Simple.Configure
  configure, called at libraries/Cabal/Cabal/Distribution/Simple.hs:625:20 in Cabal-3.0.1.0:Distribution.Simple
  confHook, called at libraries/Cabal/Cabal/Distribution/Simple/UserHooks.hs:65:5 in Cabal-3.0.1.0:Distribution.Simple.UserHooks
  configureAction, called at libraries/Cabal/Cabal/Distribution/Simple.hs:180:19 in Cabal-3.0.1.0:Distribution.Simple
  defaultMainHelper, called at libraries/Cabal/Cabal/Distribution/Simple.hs:116:27 in Cabal-3.0.1.0:Distribution.Simple
  defaultMain, called at Setup.hs:2:8 in main:Main
Setup: Encountered missing or private dependencies:
microlens-mtl >=0.1.3.1 && <0.2, optparse-applicative <0.15

builder for '/nix/store/kay0q9wh6zfxlkpqydz8r9fyma3ak807-morte-1.7.2.drv' failed with exit code 1
error: build of '/nix/store/kay0q9wh6zfxlkpqydz8r9fyma3ak807-morte-1.7.2.drv' failed

summoner{,tui}
morley
lorentz

M  pkgs/development/haskell-modules/configuration-hackage2nix.yaml
@Anton-Latukha
Copy link
Contributor Author

Yep.

Sorry.

Somehow got in.

Removed morte from this update.

@cdepillabout
Copy link
Member

Looks good, thanks for fixing this up!

@cdepillabout cdepillabout merged commit 2edbf45 into NixOS:haskell-updates Sep 22, 2020
@Anton-Latukha Anton-Latukha deleted the 2020-09-20-working-summoner branch October 11, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants