Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] lldb_5, lldb_6: add patch for >=python-3.7 #98342

Merged
merged 1 commit into from Sep 23, 2020
Merged

[20.09] lldb_5, lldb_6: add patch for >=python-3.7 #98342

merged 1 commit into from Sep 23, 2020

Conversation

maxxk
Copy link
Contributor

@maxxk maxxk commented Sep 20, 2020 •
edited

(cherry picked from commit 9f11f7a)

Backport of #97715
ZHF: #97479
cc @NixOS/nixos-release-managers

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested that Python plugin works, as per lldb doc:

script help(lldb)

@jonringer
Copy link
Contributor

172f3a1 is the commit on master

@maxxk
Copy link
Contributor Author

maxxk commented Sep 23, 2020

Done

@risicle
Copy link
Contributor

risicle commented Sep 23, 2020

WFM non-nixos linux x86_64 & macos 10.14

@risicle risicle merged commit 189520c into NixOS:release-20.09 Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer matthewbauer is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxxk @jonringer @risicle