Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform-compliance: fix build #98414

Merged
merged 1 commit into from Sep 21, 2020
Merged

terraform-compliance: fix build #98414

merged 1 commit into from Sep 21, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Disables lock of pythonPackages.ipython to allow building with what's in nixpkgs.

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
terraform-compliance: fix build
85ce380 
* Disables lock of pythonPackages.ipython to allow
    building with what's in nixpkgs
@ofborg ofborg bot requested a review from kalbasit September 21, 2020 18:48
@risicle
Copy link
Contributor

risicle commented Sep 21, 2020

WFM macos 10.14

@risicle
Copy link
Contributor

risicle commented Sep 21, 2020

WFM linux x86_64 too.

@risicle risicle merged commit 4196314 into NixOS:master Sep 21, 2020
@drewrisinger drewrisinger deleted the zhf/terraform-compliance branch September 21, 2020 21:11
@risicle risicle mentioned this pull request Oct 5, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drewrisinger @risicle