Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] xmlbird: fix build with python 3.8 #98357

Merged
merged 2 commits into from Sep 23, 2020
Merged

[20.09] xmlbird: fix build with python 3.8 #98357

merged 2 commits into from Sep 23, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 20, 2020

Motivation for this change

ZHF: #97479

Backport of #98298

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
xmlbird: fix build with python 3.8
aa7352b 
also force use of gccStdenv to fix darwin build

(cherry picked from commit 781b870)
@risicle
birdfont: fix build on non-nixos/debian systems
85575e5 
to do this we need to prevent platform.version() from using uname to
discover this is a debian kernel and try dpkg nonsense

(cherry picked from commit 0b67d9e)
@ofborg ofborg bot requested a review from dtzWill September 21, 2020 00:30
jonringer
jonringer approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 98357 1

2 packages built:
  • birdfont
  • xmlbird

@jonringer jonringer merged commit 8c4d4ea into NixOS:release-20.09 Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @jonringer