Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't rely on argparse's internal API #204

Open
FFY00 opened this issue Sep 19, 2020 · 3 comments
Open

Don't rely on argparse's internal API #204

FFY00 opened this issue Sep 19, 2020 · 3 comments
Labels
software Component: software

Comments

@FFY00
Copy link
Contributor

FFY00 commented Sep 19, 2020

The current CLI is relying on argparse internal API, this is undesirable. Everything I've seen so far could be replaced by our minimal custom implementation. Other option would be to move to a different argument parsing library, such as click.
@whitequark whitequark added the software Component: software label Sep 21, 2020
@whitequark
Copy link
Member

I reviewed a few argument parsing libraries and I didn't like any of them, so at some point likely I'll rewrite argparse.

@DurandA
Copy link

DurandA commented Sep 21, 2020

The current CLI is relying on argparse internal API

Out of curiosity, can you quote a few examples? My quick search was inconclusive.

@FFY00
Copy link
Contributor Author

FFY00 commented Sep 21, 2020

glasgow/software/glasgow/cli.py

Line 95 in bfaf933

def add_subparsers(parser, **kwargs):

@whitequark whitequark mentioned this issue Nov 14, 2020
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
software Component: software
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@whitequark @DurandA @FFY00