New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Package.aionotify: init at 0.2.0 #98406
Conversation
@jonringer Can you review it again please? |
Ping @jonringer again (and @FRidh). |
the template is there for a reason, running
|
I did try to run
Maybe I am running it wrong, but I did exactly what the PR template is showing. |
the
|
@jonringer Done, sorry for the unnecessary work. But should work now:
But I learned a lot from this PR, thanks for the inputs 👍 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the v${version}
paradigm is just help distinguish tags in version control. The version shouldn't have the prefix
also allows for the bot to update this package
@jonringer Sorry about the version thing. Anything else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 98406 1
2 packages built:
- python37Packages.aionotify
- python38Packages.aionotify
Motivation for this change
Add
python-aionotify
package: https://github.com/rbarrois/aionotifyThings done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)