Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python38Packages.shouldbe: disable for python3.8 #98329

Merged
merged 1 commit into from Sep 20, 2020
Merged

python38Packages.shouldbe: disable for python3.8 #98329

merged 1 commit into from Sep 20, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 20, 2020 •
edited

Motivation for this change

DirectXMan12/should_be#4

upstream hasn't seen any activity in more than a year. May want to consider removing the package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

mweinelt commented Sep 20, 2020 •
edited

Result of nixpkgs-review pr 98329 1

3 packages removed:
python3.8-asyncssh (†2.3.0) python3.8-gssapi (†1.6.2) python3.8-shouldbe (†0.1.2)

@mweinelt mweinelt merged commit 1696de5 into NixOS:master Sep 20, 2020
@jonringer jonringer deleted the disable-shouldbe branch September 20, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @mweinelt