Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.spyder: fix build #98407

Merged
merged 1 commit into from Sep 21, 2020
Merged

python3Packages.spyder: fix build #98407

merged 1 commit into from Sep 21, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Remove version locks that don't match what's in nixpkgs

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
python3Packages.spyder: fix build
ee2aa37 
* Remove version locks that don't match what's in nixpkgs
@drewrisinger drewrisinger changed the title pythonPackages.spyder: fix build python3Packages.spyder: fix build Sep 21, 2020
@drewrisinger drewrisinger mentioned this pull request Sep 21, 2020
Merged
10 tasks
@bcdarwin
Copy link
Member

result of nixpkgs-review on NixOS:

2 packages built:
python37Packages.spyder spyder

also, spyder3 starts, the kernels can execute code, and the editor appears to work.

jonringer
jonringer approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 98407 1

2 packages built:
  • python37Packages.spyder
  • spyder (python38Packages.spyder)

@jonringer jonringer merged commit 3b6800c into NixOS:master Sep 21, 2020
@drewrisinger drewrisinger deleted the zhf/spyder branch September 21, 2020 17:00
@drewrisinger drewrisinger mentioned this pull request Sep 21, 2020
Merged
10 tasks
@gebner
Copy link
Member

gebner commented Oct 3, 2020

This change causes a big warning message every time you start spyder: #99455

@gebner gebner mentioned this pull request Oct 3, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@drewrisinger @bcdarwin @gebner @jonringer