Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextcloud: 19.0.1 -> 19.0.3, deprecate/remove older versions #98333

Merged
merged 3 commits into from Sep 27, 2020
Merged

nextcloud: 19.0.1 -> 19.0.3, deprecate/remove older versions #98333

merged 3 commits into from Sep 27, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 20, 2020

Motivation for this change

Closes #97751.

ChangeLogs:

Also removes nextcloud17 and deprecates nextcloud18 since both will be EOLed within the lifetime of 20.09[1]. While nextcloud17 can be removed entirely now, nextcloud18 must stay (and marked as insecure) to make sure that users from Nextcloud17 can seamlessly upgrade to nextcloud19 on 20.09.

[1] https://docs.nextcloud.com/server/19/admin_manual/release_schedule.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 20, 2020
@Ma27 Ma27 added this to the 20.09 milestone Sep 20, 2020
@Ma27 Ma27 mentioned this pull request Sep 20, 2020
Closed
10 tasks
@Ma27
Copy link
Member Author

Ma27 commented Sep 26, 2020

cc @worldofpeace @jonringer I'd consider this and #98332 relevant for 20.09 :)

@worldofpeace
Copy link
Contributor

cc @worldofpeace @jonringer I'd consider this and #98332 relevant for 20.09 :)

I guess this should be a blocker then

@worldofpeace worldofpeace added this to To Do in 20.09 Blockers via automation Sep 27, 2020
jonringer
jonringer approved these changes Sep 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
tests pass

https://github.com/NixOS/nixpkgs/pull/98333
1 package marked as broken and skipped:
nextcloud18

1 package blacklisted:
tests.nixos-functions.nixos-test

1 package built:
nextcloud19

@Ma27
Copy link
Member Author

Ma27 commented Sep 27, 2020

@worldofpeace anything else to add? I'd consider this good to go and would backport after merge :)

@worldofpeace
Copy link
Contributor

I had @cole-h look at the release note and he pre-approved on IRC with my suggested changes.

@Ma27
Copy link
Member Author

Ma27 commented Sep 27, 2020

@worldofpeace @cole-h thanks, fixed :)

cole-h
cole-h approved these changes Sep 27, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 more nits, and then diff LGTM.

nixos/doc/manual/release-notes/rl-2009.xml Outdated Show resolved Hide resolved
nixos/doc/manual/release-notes/rl-2009.xml Outdated Show resolved Hide resolved
@Ma27
nixos/nextcloud: drop nextcloud17, deprecate nextcloud18
6b48dee 
Both packages will get EOLed within the lifetime of 20.09. `nextcloud17`
can be removed entirely (the attribute-path is kept however to provide
meaningful errors), however `nextcloud18` must be kept as `insecure` to
make sure that users from `nextcloud17` can properly upgrade to
`nextcloud19` on NixOS 20.09.
@Ma27 Ma27 requested a review from cole-h September 27, 2020 17:24
@Ma27
Copy link
Member Author

Ma27 commented Sep 27, 2020

@GrahamcOfBorg eval

cole-h
cole-h approved these changes Sep 27, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ma27 Ma27 merged commit 71426f2 into NixOS:master Sep 27, 2020
20.09 Blockers automation moved this from To Do to Done Sep 27, 2020
@Ma27 Ma27 deleted the bump-nextcloud branch September 27, 2020 18:02
@Ma27
Copy link
Member Author

Ma27 commented Sep 27, 2020

Backported to 20.09 as 5806ced, 3e77155, c57d809.

Package updates are also on 20.03 from #98332.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 27, 2020
@worldofpeace worldofpeace added this to In progress in 20.09 Blockers via automation Oct 5, 2020
@worldofpeace worldofpeace removed this from Done in 20.09 Blockers Oct 5, 2020
@worldofpeace worldofpeace moved this from In progress to Done in 20.09 Blockers Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachp bachp bachp approved these changes

@jonringer jonringer jonringer approved these changes

@cole-h cole-h cole-h approved these changes

@globin globin Awaiting requested review from globin

@fpletz fpletz Awaiting requested review from fpletz

@schneefux schneefux Awaiting requested review from schneefux

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: clean-up 8.has: documentation 8.has: module (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
No open projects
20.09 Blockers
  
Done
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Ma27 @worldofpeace @bachp @jonringer @cole-h @puppe