Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] libndtypes, libxnd, libgumath: unstable-2018-11-27 -> unstable-2019-08-01, to fix gumath python package & darwin #98354

Merged
merged 3 commits into from Sep 20, 2020
Merged

[20.09] libndtypes, libxnd, libgumath: unstable-2018-11-27 -> unstable-2019-08-01, to fix gumath python package & darwin #98354

merged 3 commits into from Sep 20, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 20, 2020

Motivation for this change

ZHF: #97479

Backport of #97837

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
libndtypes, pythonPackages.ndtypes: unstable-2018-11-27 -> unstable-2…
d6a9a32 
…019-08-01

this is the most recent commit to upstream's master at time of writing

includes fixes of python package for darwin

(cherry picked from commit 044533c)
@risicle
libxnd, pythonPackages.xnd: unstable-2018-11-27 -> unstable-2019-08-01
3c60b99 
this is the most recent commit to upstream's master at time of writing

includes fixes of python package for darwin

(cherry picked from commit dcd6847)
@risicle
libgumath, pythonPackages.gumath: unstable-2018-11-27 -> unstable-201…
6de705b 
…9-08-01

this is the most recent commit to upstream's master at time of writing

includes fixes of python package for darwin

(cherry picked from commit eb86bff)
jonringer
jonringer approved these changes Sep 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 98354 1

9 packages built:
  • libgumath
  • libndtypes
  • libxnd
  • python37Packages.gumath
  • python37Packages.ndtypes
  • python37Packages.xnd
  • python38Packages.gumath
  • python38Packages.ndtypes
  • python38Packages.xnd

@jonringer jonringer merged commit 29d5187 into NixOS:release-20.09 Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @jonringer