Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbvisualizer: remove #98351

Merged
merged 1 commit into from Oct 2, 2020
Merged

dbvisualizer: remove #98351

merged 1 commit into from Oct 2, 2020

Conversation

jonringer
Copy link
Contributor

Motivation for this change
  trying https://www.dbvis.com/product_download/dbvis-9.5.7/media/dbvis_unix_9_5_7.tar.gz
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404
  error: cannot download dbvis_unix_9_5_7.tar.gz from any mirror

Source has likely been broken since 2017
It's unfree, so we don't have hydra to view breakage history.

Looking at their download options, it seems they only keep the latest major.minor version. 9.5.8 would be the latest in the 9.5 series, and that patch version was released in 2017

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Source has likely been broken since 2017
It's unfree, so we don't have hydra to view breakage history.
@jonringer
Copy link
Contributor Author

cc @fooblahblah who added this in #7283

@jonringer
Copy link
Contributor Author

I'm going to take 10 days as little to no interest in this being maintained

@jonringer jonringer merged commit 1b17aea into NixOS:master Oct 2, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/misuse-of-commit-permissions/10071/43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants