spotify: support --force-device-scale-factor for high-DPI displays #98350
Conversation
9999years
changed the title
|
Thanks for taking the time to contribute! I'm not entirely sure this belongs into the package itself. Couldn't you just create a new wrapper in your |
|
I'd be fine with adding such an option to a wrapper, however I'd advise against doing this in Although rebuilding A better solution would be to create a wrapper with If you need further assistance with this, feel free to ask :) |
9999years
force-pushed
the
spotify-device-scale-factor
branch
from
a5647bc
to
f1940ce
Compare
Add a Spotify wrapper with a `deviceScaleFactor` argument to set the
`--force-device-scale-factor` flag for high-DPI displays. If unset,
nothing is added.
This allows e.g.
spotify.override { deviceScaleFactor = 1.66; }
Uses a separate wrapper derivation as suggested by @Ma27.
Uses `wrapProgram` instead of `makeWrapper` as suggested by @Ma27.
9999years
force-pushed
the
spotify-device-scale-factor
branch
from
f1940ce
to
4f03644
Compare
|
This PR has introduced some inconveniencies:
Those could be fixed (maybe by not exposing Now slightly off-topic, but I'm still a bit unconvinced why we need a spotify specific wrapper in the first place. Wouldn't something like a library function for convenient, declarative wrapping be better? environment.systemPackages = with pkgs; [
(wrapbin spotify "/bin/spotify" "--force-device-scale-factor 42")
] |
Regarding the spotify-unwrapped unfree package: NixOS/nixpkgs#98350 (comment)
Add a
deviceScaleFactorargument to set the--force-device-scale-factorin the wrapper. If unset, nothing is added.This allows e.g.
for use with high-DPI displays.
Motivation for this change
Spotify's text is tiny by default on my monitor and I didn't know there was a way to fix it. I also want the
--force-device-scale-factorargument to be the same every time i launch it, so adding an argument to the derivation seems like the best solution.Things done
sandboxinnix.confon non-NixOS linux)Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)(N/A)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)