Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate_solvespace updates #711

Merged
merged 1 commit into from Sep 22, 2020
Merged

translate_solvespace updates #711

merged 1 commit into from Sep 22, 2020

Conversation

rurban
Copy link
Contributor

@rurban rurban commented Sep 21, 2020

for all languages. See PR #705

my russian is not good enough to fix the remaining ru and uk strings.
german and french are now complete.

for all languages. See PR solvespace#705

my russian is not good enough to fix the remaining ru and uk strings.
german and french are now complete.
@phkahler
Copy link
Member

It might be slightly premature. I almost opened an issue like this yesterday, but there may be some string changes/addition/deletions due to the remaining issues before 3.0. After that we need to update the .pot file and then ask people to update the localizations. Having said that, it probably wouldn't hurt to update them whenever people are willing to do so.

I would also suggest that hot-keys try to be consistent across languages unless they're really awkward. I know English seems to get preferential treatment, but even there we have some oddities. reVolve got "V" because "R" was taken by rotate.

@phkahler phkahler merged commit 7c766c7 into solvespace:master Sep 22, 2020
@rurban rurban deleted the trans branch September 24, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants