Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

velero: init at 1.5.1 #98371

Merged
merged 2 commits into from Sep 21, 2020
Merged

Conversation

bryanasdev000
Copy link
Member

Motivation for this change

Update velero (formely heptio-ark), a utility for managing disaster recovery, specifically for Kubernetes cluster resources and persistent volumes at version 1.5.1. I removed the reference to heptio-ark and added myself as a maintainer next to @mbode. A big thanks to @mtrsk and the brazilian telegram group of NixOS for the help.

NOTE: I did not find a good way to pass the version information, so for now, they are locked directly in the package definition based on the information from the last release and its makefile, I also deactivated the tests, as it gave some sandbox-related errors and the expectation of a kubernetes environment. Perhaps in the future it will be useful to enable some of them.

Things done

Added package definition at pkgs/applications/networking/cluster/velero/default.nix, removed pkgs/applications/networking/cluster/heptio-ark/default.nix and added a reference line to pkgs/top-level/all-packages.nix where heptio-ark was.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Signed-off-by: Bryan A. S <bryanasdev000@gmail.com>
Signed-off-by: Bryan A. S <bryanasdev000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants