Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update velero (formely heptio-ark), a utility for managing disaster recovery, specifically for Kubernetes cluster resources and persistent volumes at version 1.5.1. I removed the reference to heptio-ark and added myself as a maintainer next to @mbode. A big thanks to @mtrsk and the brazilian telegram group of NixOS for the help.
NOTE: I did not find a good way to pass the version information, so for now, they are locked directly in the package definition based on the information from the last release and its makefile, I also deactivated the tests, as it gave some sandbox-related errors and the expectation of a kubernetes environment. Perhaps in the future it will be useful to enable some of them.
Things done
Added package definition at
pkgs/applications/networking/cluster/velero/default.nix
, removedpkgs/applications/networking/cluster/heptio-ark/default.nix
and added a reference line topkgs/top-level/all-packages.nix
whereheptio-ark
was.sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)