Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update luakit #98358

Closed
wants to merge 3 commits into from
Closed

update luakit #98358

wants to merge 3 commits into from

Conversation

enderger
Copy link
Member

Motivation for this change

Luakit is out of date. This PR fixes that

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

AndersonTorres
AndersonTorres suggested changes Sep 21, 2020
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @enderger! Many thanks for your contribution!

Just a small correction: rewrite the commit in the form luakit: 2.1 -> 2.2.1.

(If I'm not wrong, you can use a mere git commit --amend to edit the commit message, and then git push -fvu it.)

@enderger
Copy link
Member Author

The message should now be fixed, as a side note I am not the origional maintainer of the package, just a user who saw an out of date package. I may push some updates since they are inactive, but a new maintainer may be needed. I don't know how that works, just wanted to let you guys know.

@AndersonTorres
Copy link
Member

OK. I will update it locally, then.

@AndersonTorres AndersonTorres mentioned this pull request Sep 22, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@enderger @AndersonTorres @Janik-Haag