New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove an unnecessary null pointer check #703

Closed

elfring opened this issue Sep 18, 2020 · 1 comment

elfring commented Sep 18, 2020

An extra null pointer check is not needed in the function “List::Clear”.

Member

phkahler commented Sep 21, 2020 •

edited

Any effort to change List or IdList should first have a look at PRs #429 and #433, and also the following experiment which apparently has profound performance implications: https://github.com/Evil-Spirit/solvespace-master/commits/id-list-indexing

That said, make a PR instead of opening an issue :-)

phkahler closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment