gnat-wrapper/cc-wrapper cleanup and fixes. #98369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shellcheck utility looks for lines starting with "# shellcheck" and treats those as directives controlling it's use. These lines start that way, but are not actual shellcheck directives, causing it to emit errors and fail. This patch adjusts the comments so that shellcheck does not perceive them as directives.
These do not break the Ada compilations done with gcc, but they cause three warnings about unused flags to be emitted with each compilation.
|
I must admit my understanding of these scripts do not go beyond "it works or it doesn't". I don't see anything problematic. Given you're changing cc-wrapper though, I believe this PR should target |
10 tasks
|
Good point. I've opened #99027 against staging to replace this PR. |
|
For future reference, you can change the target branch without creating a
new PR.
…On Mon, Sep 28, 2020, 21:52 Kevin Quick ***@***.***> wrote:
Closed #98369 <#98369>.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#98369 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAS7M4RCU57DUQ2D4STSSCTSIDSPXANCNFSM4RUCRDCA>
.
|
|
How? I looked for a way to do that and didn't find anything, but I would have liked to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Observation of #98274 which fixed the gnat issue I also encountered led to some additional cleanup and corner-case fixes in both the gnat-wrapper, the cc-wrapper, and the role.bash setup hook.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)