Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adobe-reader: add gkd-pixbuf-xlib based on issue: #96683 #96693

Merged
merged 1 commit into from Sep 17, 2020
Merged

adobe-reader: add gkd-pixbuf-xlib based on issue: #96683 #96693

merged 1 commit into from Sep 17, 2020

Conversation

jmininger
Copy link
Contributor

@jmininger jmininger commented Aug 30, 2020 •
edited

Motivation for this change

acroreader failed to run, see #96683

Things done

Added gdk-pixbuf-xlib to the lib path

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Ericson2314
Ericson2314 approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most recent comment on the isssue (#96683 (comment)) makes seem this seem pretty clear-cut better than before.

@Ericson2314 Ericson2314 merged commit d30161b into NixOS:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmininger @Ericson2314 @Janik-Haag