Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.blis: add missing dependency numpy #96664

Merged
merged 1 commit into from Aug 30, 2020
Merged

pythonPackages.blis: add missing dependency numpy #96664

merged 1 commit into from Aug 30, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Aug 30, 2020

Motivation for this change

blis' numpy dependency seems to have been falsely satisfied by its inclusion in checkInputs, whereas this seems to actually be an install dependency. This can be demonstrated by attempting to build this package with doCheck = false and watching it fail.

Also removed cython from checkInputs as it's already in nativeBuildInputs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
pythonPackages.blis: add missing dependency numpy
4b3f8bd 
blis' numpy dependency seems to have been falsely satisfied by its
inclusion in checkInputs, whereas this seems to actually be an install
dependency. this can be demonstrated by attempting to build this package
with doCheck = false and watching it fail.

also removed cython from checkInputs as it's already in nativeBuildInputs
@ofborg ofborg bot requested a review from danieldk August 30, 2020 10:34
@danieldk
Copy link
Contributor

Thanks!

Result of nixpkgs-review pr 96664 1

9 packages built:
- python27Packages.blis
- python37Packages.blis
- python37Packages.spacy
- python37Packages.textacy
- python37Packages.thinc
- python38Packages.blis
- python38Packages.spacy
- python38Packages.textacy
- python38Packages.thinc

blis indeed failed when importing an actual function (e..g. from blis.py import einsum).

@danieldk danieldk merged commit b4631b0 into NixOS:master Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @danieldk