Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

navi: 2.9.0 -> 2.10.0 #96694

Merged
merged 1 commit into from Sep 7, 2020
Merged

navi: 2.9.0 -> 2.10.0 #96694

merged 1 commit into from Sep 7, 2020

Conversation

cust0dian-old
Copy link
Contributor

Motivation for this change

https://github.com/denisidoro/navi/releases/tag/v2.10.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cust0dian-old
Copy link
Contributor Author

cust0dian-old commented Aug 30, 2020 •
edited

This release adds support for using output of tldr as a cheatsheet, but not all tldr clients are supported. Ideally, users would use tealdeer, but it requires managing cache — I'm not sure if it can be or should be addressed during packaging, or if we should leave it up to users to decide what tldr client to use?

@marsam marsam merged commit 7c6fda9 into NixOS:master Sep 7, 2020
@cust0dian-old cust0dian-old deleted the navi-2.10.0 branch September 7, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cust0dian-old @tomberek @marsam @cust0dian