Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mackerel-agent: init at 0.69.3 #96679

Merged
merged 2 commits into from Nov 11, 2020
Merged

mackerel-agent: init at 0.69.3 #96679

merged 2 commits into from Nov 11, 2020

Conversation

midchildan
Copy link
Member

Motivation for this change

mackerel-agent is a client program for the mackerel.io monitoring service.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@midchildan
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 30, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@midchildan midchildan force-pushed the add-mackerel branch 2 times, most recently from c8d118b to ae32711 Compare August 30, 2020 15:59
@ofborg ofborg bot requested a review from kalbasit August 30, 2020 18:06
jonringer
jonringer reviewed Aug 30, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for nixos modules, the commit is usually structured:

nixos/<name>:<message>

To comply with CONTRIBUTING.md please have the commit message name be of the format

<pkg-name>: <subject-line>

for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

in your case, the commit message should be:

nixos/mackeral-agent: init

pkgs/servers/monitoring/mackerel-agent/default.nix
subPackages = [ "." ];

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default

Suggested change
subPackages = [ "." ];

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built the package without it, no, it does not.

pkgs/servers/monitoring/mackerel-agent/default.nix Outdated Show resolved Hide resolved
pkgs/servers/monitoring/mackerel-agent/default.nix Outdated Show resolved Hide resolved
pkgs/servers/monitoring/mackerel-agent/default.nix Outdated Show resolved Hide resolved
pkgs/servers/monitoring/mackerel-agent/default.nix Outdated Show resolved Hide resolved
@midchildan
Copy link
Member Author

Fixed

@midchildan
Copy link
Member Author

midchildan commented Nov 7, 2020 •
edited

bumped the version and rebased.

@midchildan midchildan changed the title mackerel-agent: init at 0.68.2 mackerel-agent: init at 0.69.3 Nov 7, 2020
@marvin-mk2 marvin-mk2 bot requested a review from kevincox November 11, 2020 03:23
@kevincox kevincox merged commit 5dee9b5 into NixOS:master Nov 11, 2020
@midchildan midchildan deleted the add-mackerel branch November 11, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

@kevincox kevincox Awaiting requested review from kevincox

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@midchildan @jonringer @kevincox