Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fwupd: Add upstream patch to fix build with systemd 246 #96696

Merged
merged 1 commit into from Aug 31, 2020
Merged

fwupd: Add upstream patch to fix build with systemd 246 #96696

merged 1 commit into from Aug 31, 2020

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Aug 30, 2020

Motivation for this change

Fixes build failure with systemd 246 (#96663).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andersk
fwupd: Add upstream patch to fix build with systemd 246
51632d5 
Fixes NixOS#96663.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk andersk added 0.kind: regression Something that worked before working no longer 1.severity: channel blocker Blocks a channel 11.by: nixpkgs-member labels Aug 30, 2020
@ofborg ofborg bot requested a review from jtojnar August 30, 2020 22:57
@vcunat vcunat merged commit bbc52af into NixOS:master Aug 31, 2020
@andersk andersk deleted the fwupd-build branch December 26, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
0.kind: regression Something that worked before working no longer 1.severity: channel blocker Blocks a channel 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: nixpkgs-member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andersk @vcunat