erlang: make configureFlags appending instead of overwriting
#96668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The erlang `generic-builder` accepts a lot of arguments that would affect the `configureFlags` passed to `mkDerivation`. Though all these arguments would be without any effect if additionally `configureFlags` is passed and not the empty list. This change should make it easier to "compose" arbitrary erlang overrides.
|
cc erlang folks @tolbrino @cw789 @michalmuskala @madjar |
|
lgtm 👍 |
worldofpeace
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The erlang
generic-builderaccepts a lot of arguments that wouldaffect the
configureFlagspassed tomkDerivation. Though all thesearguments would be without any effect if additionally
configureFlagsis passed and not the empty list.
This change should make it easier to "compose" arbitrary erlang overrides.
I am aware that this change is potentially a breaking change, especially about how erlang might be used by nix-users, but probably not within nixpkgs itself (I think the issue would have been seen earlier if it was used that way in nixpkgs itself). Therefore I suggest to not make this change available before 20.09.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Even though I ticked run of "nixpkgs-review", I'm not quite sure if it did what it was expected to do, as it told me "No diff detected, stopping review...".
I tested the binary files only for the top-level
erlangattribute as well as for one specific override. I expect other variants to work the same, and possible compbinations are just to much…