Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/availableKernelModules: add microsoft hid #96639

Merged
merged 1 commit into from Nov 5, 2020
Merged

nixos/availableKernelModules: add microsoft hid #96639

merged 1 commit into from Nov 5, 2020

Conversation

KamilaBorowska
Copy link
Member

This adds support for Microsoft USB keyboards at boot.

Motivation for this change

I'm using Microsoft Natural Ergonomic Keyboard 4000 (a wired USB keyboard) and without loading this module the kernel is unable to accept keyboard input during boot. nixos-generate-config doesn't load the right module (when seeing this keyboard it adds usbhid onto the module list), and from I can tell it's non-trivial to fix that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KamilaBorowska
nixos/availableKernelModules: add microsoft hid
bcc93f0 
This adds support for Microsoft USB keyboards at boot.
@KamilaBorowska
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Oct 12, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Oct 12, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

vikanezrimaya
vikanezrimaya approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@vikanezrimaya vikanezrimaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering that we do seem to have these kinds of special cases on availableKernelModules already, I'd say this is not unreasonable.

LGTM.

@vikanezrimaya
Copy link
Member

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from timokau November 5, 2020 13:13
@timokau
Copy link
Member

timokau commented Nov 5, 2020

I am not really sure what implications this has. @NeQuissimus as our "kernel guy", do you have an opinion on this PR?

@NeQuissimus
Copy link
Member

NeQuissimus commented Nov 5, 2020 •
edited

Considering the Logitechs are in there already, we can probably add the MS one. But this shouldn't get out of control and eventually end up behind some switch :)

@timokau timokau merged commit 1fd1c2a into NixOS:master Nov 5, 2020
@Luflosi Luflosi mentioned this pull request Feb 1, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikanezrimaya vikanezrimaya vikanezrimaya approved these changes

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KamilaBorowska @vikanezrimaya @timokau @NeQuissimus