Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home assistant plugins: pysqueezebox and yeelight #96689

Closed
wants to merge 5 commits into from

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Aug 30, 2020

Motivation for this change

Tested on my server and working

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

sha256 = "02d73e98314a63a38c314d40942a0b098fb59d2f08ac39b2627cfa73f785cf0d";
};

doCheck = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests are not available, then please use pythonImportsCheck to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors. Please see pythonImportsCheck documentation for more information.

and please comment as to why tests were disabled.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are not available in the Pypi tar.gz but thanks for the pythonImportsCheck, I didn't know that !

Copy link
Member

@mweinelt mweinelt Sep 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried pulling the package from GitHub then? Having the tests would be much better in the long run.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the dev, the tests are a work in progress. That's why they are not included.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough.

pkgs/development/python-modules/pysqueezebox/default.nix Outdated Show resolved Hide resolved
Co-authored-by: Jon <jonringer@users.noreply.github.com>
@jonringer
Copy link
Contributor

sorry, I sorted python-packages.nix please reabase on latest master and re-sort the entries please :)

@jonringer
Copy link
Contributor

i sorted python-packages.nix, please rebase on top of latest master

@nyanloutre
Copy link
Member Author

I tried the GitHub tool to resolve the conflict and it did a merge, do you want a clean rebase or is it ok ?

@mweinelt
Copy link
Member

mweinelt commented Sep 4, 2020

Yes, please aim for a clean history.

@nyanloutre nyanloutre deleted the home_assistant_plugins branch September 9, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants