New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home assistant plugins: pysqueezebox and yeelight #96689
Conversation
096dd7f
to
43d23e0
Compare
sha256 = "02d73e98314a63a38c314d40942a0b098fb59d2f08ac39b2627cfa73f785cf0d"; | ||
}; | ||
|
||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If tests are not available, then please use pythonImportsCheck
to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors. Please see pythonImportsCheck documentation for more information.
and please comment as to why tests were disabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests are not available in the Pypi tar.gz but thanks for the pythonImportsCheck
, I didn't know that !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried pulling the package from GitHub then? Having the tests would be much better in the long run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the dev, the tests are a work in progress. That's why they are not included.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough.
Co-authored-by: Jon <jonringer@users.noreply.github.com>
sorry, I sorted python-packages.nix please reabase on latest master and re-sort the entries please :) |
i sorted python-packages.nix, please rebase on top of latest master |
I tried the GitHub tool to resolve the conflict and it did a merge, do you want a clean rebase or is it ok ? |
Yes, please aim for a clean history. |
Motivation for this change
Tested on my server and working
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)