Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mympd: init at 6.8.1 #96673

Merged
merged 1 commit into from Dec 4, 2020
Merged

mympd: init at 6.8.1 #96673

merged 1 commit into from Dec 4, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Aug 30, 2020 •
edited

Motivation for this change

Add a maintained fork of ympd.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar doronbehar force-pushed the pkg/mympd branch 2 times, most recently from df802f6 to 86643a1 Compare September 3, 2020 08:28
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 96673 run on x86_64-linux 1

1 package built:
  • mympd

SuperSandro2000
SuperSandro2000 reviewed Nov 25, 2020
View reviewed changes
pkgs/applications/audio/mympd/default.nix Outdated
Comment on lines 47 to 52
meta = {
homepage = "https://jcorporation.github.io/myMPD/";
description = "A standalone and mobile friendly web mpd client with a tiny footprint and advanced features";
maintainers = [ stdenv.lib.maintainers.doronbehar ];
platforms = stdenv.lib.platforms.unix;
license = stdenv.lib.licenses.gpl2Plus;
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = {
homepage = "https://jcorporation.github.io/myMPD/";
description = "A standalone and mobile friendly web mpd client with a tiny footprint and advanced features";
maintainers = [ stdenv.lib.maintainers.doronbehar ];
platforms = stdenv.lib.platforms.unix;
license = stdenv.lib.licenses.gpl2Plus;
};
meta = with stdenv.lib; {
homepage = "https://jcorporation.github.io/myMPD/";
description = "A standalone and mobile friendly web mpd client with a tiny footprint and advanced features";
maintainers = with maintainers; [ doronbehar ];
platforms = platforms.unix;
license = licenses.gpl2Plus;
};

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a stylistic preference which has it's advantages and is legitimate but there is no such rule for it.

@SuperSandro2000
Copy link
Member

Fails to build on darwin:

building
build flags: -j4 -l4 SHELL=/nix/store/k89nm2jva0qmvd970f84wq2iq1iwm9bs-bash-4.4-p23/bin/bash
Scanning dependencies of target mympd
Scanning dependencies of target mympd-script
Scanning dependencies of target mympd-config
[  1%] Building C object cli_tools/CMakeFiles/mympd-script.dir/__/dist/src/mongoose/mongoose.c.o
[  2%] Building C object cli_tools/CMakeFiles/mympd-config.dir/mympd-config.c.o
[  3%] Building C object cli_tools/CMakeFiles/mympd-script.dir/mympd-script.c.o
[  3%] Building C object CMakeFiles/mympd.dir/src/main.c.o
clang-7: error: argument unused during compilation: '-pie' [-Werror,-Wunused-command-line-argument]
clang-7: error: argument unused during compilation: '-s' [-Werror,-Wunused-command-line-argument]
make[2]: *** [cli_tools/CMakeFiles/mympd-script.dir/build.make:95: cli_tools/CMakeFiles/mympd-script.dir/__/dist/src/mongoose/mongoose.c.o] Error 1
make[2]: *** Waiting for unfinished jobs....
clang-7: error: argument unused during compilation: '-pie' [-Werror,-Wunused-command-line-argument]
clang-7: error: argument unused during compilation: '-s' [-Werror,-Wunused-command-line-argument]
clang-7: error: argument unused during compilation: '-pie' [-Werror,-Wunused-command-line-argument]
clang-7: error: argument unused during compilation: '-s' [-Werror,-Wunused-command-line-argument]
make[2]: *** [cli_tools/CMakeFiles/mympd-config.dir/build.make:82: cli_tools/CMakeFiles/mympd-config.dir/mympd-config.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:171: cli_tools/CMakeFiles/mympd-config.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make[2]: *** [cli_tools/CMakeFiles/mympd-script.dir/build.make:82: cli_tools/CMakeFiles/mympd-script.dir/mympd-script.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:144: cli_tools/CMakeFiles/mympd-script.dir/all] Error 2
clang-7: error: argument unused during compilation: '-pie' [-Werror,-Wunused-command-line-argument]
clang-7: error: argument unused during compilation: '-s' [-Werror,-Wunused-command-line-argument]
make[2]: *** [CMakeFiles/mympd.dir/build.make:82: CMakeFiles/mympd.dir/src/main.c.o] Error 1
make[2]: *** Waiting for unfinished jobs....
[  4%] Building C object CMakeFiles/mympd.dir/src/api.c.o
[  5%] Building C object CMakeFiles/mympd.dir/src/list.c.o
[  6%] Building C object CMakeFiles/mympd.dir/src/global.c.o
clang-7: error: argument unused during compilation: '-pie' [-Werror,-Wunused-command-line-argument]
clang-7: error: argument unused during compilation: '-s' [-Werror,-Wunused-command-line-argument]
make[2]: *** [CMakeFiles/mympd.dir/build.make:95: CMakeFiles/mympd.dir/src/api.c.o] Error 1
clang-7: error: argument unused during compilation: '-pie' [-Werror,-Wunused-command-line-argument]
clang-7: error: argument unused during compilation: '-s' [-Werror,-Wunused-command-line-argument]
clang-7: error: argument unused during compilation: '-pie' [-Werror,-Wunused-command-line-argument]
clang-7: error: argument unused during compilation: '-s' [-Werror,-Wunused-command-line-argument]
make[2]: *** [CMakeFiles/mympd.dir/build.make:108: CMakeFiles/mympd.dir/src/global.c.o] Error 1
make[2]: *** [CMakeFiles/mympd.dir/build.make:121: CMakeFiles/mympd.dir/src/list.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:117: CMakeFiles/mympd.dir/all] Error 2
make: *** [Makefile:149: all] Error 2

@doronbehar
Copy link
Contributor Author

Disabled the darwin build.

@doronbehar
Copy link
Contributor Author

Updated it to it's latest after a rebase.

SuperSandro2000
SuperSandro2000 reviewed Nov 26, 2020
View reviewed changes
pkgs/applications/audio/mympd/default.nix Outdated
hardeningDisable = [ "strictoverflow" ];

meta = {
homepage = "https://jcorporation.github.io/myMPD/";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage = "https://jcorporation.github.io/myMPD/";
homepage = "https://jcorporation.github.io/mympd";

Your link 404s.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch :).

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 96673 run on x86_64-linux 1

1 package built:
  • mympd

@doronbehar doronbehar changed the title mympd: init at 6.5.2 mympd: init at 6.8.1 Nov 26, 2020
@doronbehar
Copy link
Contributor Author

Will merge after CI is green.

@doronbehar doronbehar merged commit f06af92 into NixOS:master Dec 4, 2020
@doronbehar doronbehar deleted the pkg/mympd branch December 4, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@sikmir sikmir Awaiting requested review from sikmir

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doronbehar @SuperSandro2000 @sikmir