Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustscan: set platform to platforms.all #1234 #96644

Closed
wants to merge 1 commit into from
Closed

rustscan: set platform to platforms.all #1234 #96644

wants to merge 1 commit into from

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change

Reviewing guidelines state this should be added. Also the creator put effort in the past into the tool to get it working correctly on mac.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq
Copy link
Contributor

zowoq commented Aug 29, 2020

Not needed as buildRustPackage sets meta.platforms.

nixpkgs/pkgs/build-support/rust/default.nix

Lines 244 to 247 in 5cfd827

meta = {
# default to Rust's platforms
platforms = rustc.meta.platforms;
} // meta;

@zowoq zowoq closed this Aug 29, 2020
@SuperSandro2000 SuperSandro2000 deleted the rustscan-platforms branch August 30, 2020 00:00
@SuperSandro2000 SuperSandro2000 changed the title rustscan: set platform to platforms.all rustscan: set platform to platforms.all #1234 Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @zowoq