Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovim-qt: Add homepage. #96678

Merged
merged 3 commits into from Aug 31, 2020
Merged

neovim-qt: Add homepage. #96678

merged 3 commits into from Aug 31, 2020

Conversation

kevincox
Copy link
Contributor

@kevincox kevincox commented Aug 30, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kevincox kevincox requested a review from timokau August 30, 2020 13:44
jonringer
jonringer reviewed Aug 30, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the fix-up commits.

This can be done with:

git reset HEAD~1                    # move fix-up commits into unstaged
git add -- pkgs/                    # move changes into staged
git commit --amend --no-edit        # add changes to previous commit
git push ... ... --force            # modify current PR branch

pkgs/applications/editors/neovim/qt.nix Outdated Show resolved Hide resolved
@kevincox
Update pkgs/applications/editors/neovim/qt.nix
79b4e5b 
Co-authored-by: Jon <jonringer@users.noreply.github.com>
@kevincox
Copy link
Contributor Author

squash the fix-up commits

I will squash before merging.

@timokau
Copy link
Member

timokau commented Aug 31, 2020

Diff looks good to me, can be merged after said squashing 👍.

@kevincox kevincox merged commit 599089e into master Aug 31, 2020
@kevincox kevincox deleted the kevincox-patch-1 branch August 31, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevincox @timokau @jonringer