Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

octoprint.python.pkgs.octoprint-dashboard: init at 1.13.0 #96688

Merged
merged 3 commits into from Sep 6, 2020
Merged

octoprint.python.pkgs.octoprint-dashboard: init at 1.13.0 #96688

merged 3 commits into from Sep 6, 2020

Conversation

j0hax
Copy link
Member

@j0hax j0hax commented Aug 30, 2020 •
edited

Motivation for this change

Added the plugin Octoprint-Dashboard and its optional dependency Octoprint-DisplayLayerProgress

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

trepetti
trepetti reviewed Sep 3, 2020
View reviewed changes
Copy link
Contributor

@trepetti trepetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but it should be split into three commits with rebase/force-push. I realize this is a pain, but I think it will make it easier to get merged since they take the commit log seriously (for good reason).

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/applications/misc/octoprint/plugins.nix Show resolved Hide resolved
pkgs/applications/misc/octoprint/plugins.nix Show resolved Hide resolved
pkgs/applications/misc/octoprint/plugins.nix Show resolved Hide resolved
@trepetti
Copy link
Contributor

trepetti commented Sep 5, 2020

@ofborg eval

@trepetti
Copy link
Contributor

trepetti commented Sep 5, 2020

Not sure what this error is and wanna see in more detail what is going wrong.

@j0hax
Copy link
Member Author

j0hax commented Sep 5, 2020

Strange, must have been a one-time error.

trepetti
trepetti approved these changes Sep 5, 2020
View reviewed changes
Copy link
Contributor

@trepetti trepetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/215

@gebner gebner merged commit 955fe4d into NixOS:master Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trepetti trepetti trepetti approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@j0hax @trepetti @nixos-discourse @gebner