Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/syncthing: add ignoreDelete folder option #96659

Merged
merged 1 commit into from Sep 5, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Aug 30, 2020

Motivation for this change

An advanced folder option which is impossible to define declaratively without this patch.

Things done

Tested it works:

Screenshot from 2020-08-30 11-09-48

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

just a heads up, syncthing was broken in staging due to some of the python packages no longer working with python2. This may need some additional work to get a working syncthing again

@Lassulus
Copy link
Member

Lassulus commented Sep 5, 2020

not sure why syncthing should depend on python2? its written in go.

@Lassulus Lassulus merged commit 964606d into NixOS:master Sep 5, 2020
@doronbehar
Copy link
Contributor Author

Thanks!

@doronbehar doronbehar deleted the module/syncthing branch March 2, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants