Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/samba: remove upstream deprecated syncPasswordsByPam option #96672

Merged
merged 1 commit into from Oct 4, 2020
Merged

nixos/samba: remove upstream deprecated syncPasswordsByPam option #96672

merged 1 commit into from Oct 4, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Aug 30, 2020 •
edited

Motivation for this change

Resolve / Fix #54492 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar doronbehar mentioned this pull request Aug 30, 2020
Closed
@ajs124 ajs124 requested a review from dasJ September 9, 2020 23:32
@doronbehar doronbehar merged commit 9544c60 into NixOS:master Oct 4, 2020
@eadwu
Copy link
Member

eadwu commented Oct 4, 2020

You missed a section

      ${optionalString config.services.samba.syncPasswordsByPam
        "mr ${pkgs.samba}/lib/security/pam_smbpass.so,"}

@doronbehar
Copy link
Contributor Author

@eadwu what did I miss? git grep syncPasswordsByPam lists only the line with mkRemovedOptionModule.

NeQuissimus added a commit to NeQuissimus/nixpkgs that referenced this pull request Oct 5, 2020
@NeQuissimus
pam: Fix interaction with samba
9646ae9 
9544c60 / NixOS#96672 removed the samba option
`syncPasswordsByPam`.
Need to remove this option from the pam module, otherwise it will cause build errors
@NeQuissimus NeQuissimus mentioned this pull request Oct 5, 2020
Merged
10 tasks
Luz pushed a commit to Luz/nixpkgs that referenced this pull request Nov 5, 2020
@NeQuissimus @Luz
pam: Fix interaction with samba
0f2780a 
9544c60 / NixOS#96672 removed the samba option
`syncPasswordsByPam`.
Need to remove this option from the pam module, otherwise it will cause build errors
@doronbehar doronbehar deleted the module/samba branch March 2, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aneeshusa aneeshusa aneeshusa approved these changes

@dasJ dasJ Awaiting requested review from dasJ

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

services.samba.syncPasswordsByPam broken because pam_smbpass.so doesn't exist
3 participants
@doronbehar @eadwu @aneeshusa