Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytorch-bin: init at 1.6.0 #96669

Merged
merged 1 commit into from Aug 30, 2020
Merged

pytorch-bin: init at 1.6.0 #96669

merged 1 commit into from Aug 30, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

PyTorch from the binary wheel. This is especially handy for users that need PyTorch with CUDA support or compiled against MKL, but do not have the resources to do a full PyTorch build when there are some changes in PyTorch or its transitive dependencies.

Tested with CPU and CUDA.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

I'm assuming that we should add a comment about keeping the two version in sync for dependency reasons. Something like:

  # dont forget to update pytorch{,-bin} to the same version
  version = "1.6.0";

would help when reviewing r-ryantm PRs

@danieldk
Copy link
Contributor Author

I'm assuming that we should add a comment about keeping the two version in sync for dependency reasons. Something like:

  # dont forget to update pytorch{,-bin} to the same version
  version = "1.6.0";

would help when reviewing r-ryantm PRs

Added.

@jonringer
Copy link
Contributor

also, this PR is a palindrome :)

jonringer
jonringer approved these changes Aug 30, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 96669 1

2 packages built:
- python37Packages.pytorch-bin
- python38Packages.pytorch-bin

@jonringer jonringer merged commit 33b21ae into NixOS:master Aug 30, 2020
@danieldk danieldk deleted the pytorch-bin-1.6.0 branch August 30, 2020 18:48
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/improving-nixos-data-science-infrastructure-ci-for-mkl-cuda/5074/44

@573 573 mentioned this pull request Sep 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @jonringer @nixos-discourse