Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

droopy: use python 3.7 for macpath #96671

Merged
merged 1 commit into from Aug 31, 2020
Merged

droopy: use python 3.7 for macpath #96671

merged 1 commit into from Aug 31, 2020

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Aug 30, 2020 •
edited

Motivation for this change

The macpath module droopy uses got removed in python 3.8. Use Python 2.7 for droopy, since droopy originally targets that version.

cc @Profpatsch

Upstream issue, main problem is that droopy is unmaintained.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mindavi
Copy link
Contributor

Mindavi commented Aug 30, 2020

Have you tried using the suggested method of replacing macpath with os.path? That seems like a better solution to me. Are you still using Mac OS X 9 or lower? It seems like the macpath module is mainly focused on support for that.

I'm not sure what the stance of nixpkgs / the nixpkgs maintainers is, but I'd like to see python 2.7 usage reduced to a minimum if possible.

I'd wager it wouldn't be a big path to move to os.path usage, but I'm not sure about that.

@jonringer
Copy link
Contributor

I would much rather have python3.7.

python2 has been EOL for 2/3's of a year now

@sternenseemann
Copy link
Member Author

Good point, then I'd say we go with python 3.7. I'd rather start patching later than sooner personally.

@sternenseemann sternenseemann changed the title droopy: use python 2.7 for macpath droopy: use python 3.7 for macpath Aug 30, 2020
@sternenseemann
droopy: use python 3.7 for macpath
1e89f9f 
droopy uses the macpath module which got removed in python 3.8. Pinning
the python version to 3.7 fixes the ensuing runtime failure (for now).
jonringer
jonringer approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

https://github.com/NixOS/nixpkgs/pull/96671
1 package built:
droopy

@jonringer jonringer merged commit 784e32e into NixOS:master Aug 31, 2020
@sternenseemann sternenseemann deleted the droopy-python2.7 branch August 31, 2020 19:15
@Profpatsch
Copy link
Member

thx sterni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sternenseemann @Mindavi @jonringer @Profpatsch