cut-the-crap: Depend on c2hs #96681
Closed
cut-the-crap: Depend on c2hs #96681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the 1.4.x builds less broken. I made a 1.4.1 release that also includes the header files now. To debug further I need the hackage be regenerated. The root cause of this breakage is the added dependency of pocketsphinx. cabal2nix seems to be able to figure that part out, but not something like c2hs, and I just didn't know header files wouldn't be included in the sdist. (I though specifying an include dir was enough).
| @@ -722,6 +722,7 @@ self: super: builtins.intersectAttrs super { | |||
| cut-the-crap = | |||
| let path = pkgs.stdenv.lib.makeBinPath [ pkgs.ffmpeg_3 ]; | |||
| in overrideCabal (addBuildTool super.cut-the-crap pkgs.makeWrapper) (_drv: { | |||
| libraryToolDepends = [ self.c2hs ]; | |||
There was a problem hiding this comment.
Is c2hs not in the .cabal file upstream? If not, could you fix it by sending a PR upstream?
Also, if I remember correctly, I think the maintainer of cut-the-crap is active here in nixpkgs. You might want to directly ping them for any reviews/questions.
There was a problem hiding this comment.
Ah I realize now I can just add it to the cabal, thanks for that, that's a much neater solution. It's fixed in 1.4.2, should build again on next update of haskell packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This makes the 1.4.x builds less broken: It evaluates and starts building now at least.
The header file is still missing, which is fixed in the 1.4.1 release.
To debug further I need the hackage be regenerated.
The root cause of this breakage is the added dependency of pocketsphinx.
cabal2nix seems to be able to figure that part out,
but not something like c2hs (arguably this is a bug in cabal2nix),
I suppose few people link directly to C.
I just didn't know header
files wouldn't be included in the sdist. (I thought specifying an
include dir was enough).
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)I can't quite test untill hackage gets regenerated. I just want to make it build at least.
nix path-info -Sbefore and after)