Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md: update stable release links to 20.09 #97141

Merged
merged 1 commit into from Oct 27, 2020
Merged

README.md: update stable release links to 20.09 #97141

merged 1 commit into from Oct 27, 2020

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Update the release links to point to upcoming release

The related hydra jobs haven't been created yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

I think there's the couple other things you could get out of the way in one PR as a draft @jonringer
https://github.com/NixOS/nixpkgs/pull/85186/files
(minus the date in the release notes)

@worldofpeace worldofpeace added this to To Do in 20.09 Blockers via automation Sep 4, 2020
@worldofpeace worldofpeace added this to the 20.09 milestone Sep 4, 2020
@jonringer
Copy link
Contributor Author

just need to do the final release date in the release notes

@worldofpeace worldofpeace moved this from To Do to In progress in 20.09 Blockers Oct 2, 2020
Jiehong
Jiehong approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@Jiehong Jiehong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@worldofpeace worldofpeace added this to In progress in 20.09 Blockers Oct 5, 2020
@jonringer jonringer self-assigned this Oct 19, 2020
@worldofpeace worldofpeace marked this pull request as ready for review October 27, 2020 00:08
@worldofpeace worldofpeace merged commit 30f6f95 into NixOS:master Oct 27, 2020
20.09 Blockers automation moved this from In progress to Done Oct 27, 2020
@jonringer jonringer deleted the update-readme-for-20.09 branch February 13, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiehong Jiehong Jiehong approved these changes

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees

@jonringer jonringer

Labels
6.topic: nixos 6.topic: policy discussion 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
No open projects
20.09 Blockers
  
In progress
20.09 Blockers
  
Done
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonringer @worldofpeace @Jiehong @ryantm