Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] Backport rustup fix from master #97143

Merged
merged 1 commit into from Sep 4, 2020
Merged

[20.03] Backport rustup fix from master #97143

merged 1 commit into from Sep 4, 2020

Conversation

bjornfor
Copy link
Contributor

@bjornfor bjornfor commented Sep 4, 2020

Motivation for this change

rustup is broken on release-20.03 (missing zlib). Backport fix from master to unbreak it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Mic92 September 4, 2020 18:13
jonringer
jonringer approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 97143 1

1 package built:
  • rustup

@jonringer jonringer merged commit 51d115a into NixOS:release-20.03 Sep 4, 2020
@bjornfor bjornfor deleted the backport-rustup-fix branch September 5, 2020 04:47
@bjornfor
Copy link
Contributor Author

bjornfor commented Sep 5, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bjornfor @jonringer @Gerschtli