Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plujain-ramp: init at v1.1.3 #97140

Merged
merged 2 commits into from Jan 1, 2021
Merged

plujain-ramp: init at v1.1.3 #97140

merged 2 commits into from Jan 1, 2021

Conversation

hirenashah
Copy link
Contributor

@hirenashah hirenashah commented Sep 4, 2020 •
edited

Motivation for this change

Add plujain-ramp LV2 plugin at v1.1.3 version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hirenashah
Copy link
Contributor Author

My first contribution. More to come! Could you please review? @magnetophon

magnetophon
magnetophon suggested changes Sep 6, 2020
View reviewed changes
pkgs/applications/audio/plujain-ramp/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/plujain-ramp/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@magnetophon magnetophon self-requested a review September 8, 2020 15:01
magnetophon
magnetophon approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@magnetophon magnetophon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
builds and runs.

SuperSandro2000
SuperSandro2000 requested changes Dec 29, 2020
View reviewed changes
pkgs/applications/audio/plujain-ramp/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/plujain-ramp/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/plujain-ramp/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/plujain-ramp/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

@hirenashah please fix the merge conflict.

@hirenashah
Copy link
Contributor Author

@SuperSandro2000 Thanks for the comments. All resolved.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 97140 run on x86_64-linux 1

1 package built:
  • plujain-ramp

@SuperSandro2000 SuperSandro2000 merged commit d841f37 into NixOS:master Jan 1, 2021
@hirenashah hirenashah deleted the plujain-ramp branch July 30, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@dali99 dali99 dali99 approved these changes

@magnetophon magnetophon magnetophon approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hirenashah @SuperSandro2000 @dali99 @magnetophon @Janik-Haag