Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libextractor: 1.9 -> 1.11, add me as maintainer #97142

Merged
merged 1 commit into from Feb 9, 2021
Merged

libextractor: 1.9 -> 1.11, add me as maintainer #97142

merged 1 commit into from Feb 9, 2021

Conversation

jorsn
Copy link
Member

@jorsn jorsn commented Sep 4, 2020 •
edited

  • removed upstreamed patches
  • enabled installCheckPhase (they work, now!)
  • bumped version
  • updated license (gpl2+ -> gpl3+): according to the libextractor docs,
    it was licensed under gpl3+ since version 0.7!
  • added myself as maintainer
Motivation for this change
  • updates are good: 1.9 -> 1.11
  • i'm better than no maintainer
  • tests are good
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after): 79 kB
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jorsn jorsn requested review from vrthra, viric and ck3d September 4, 2020 17:29
@jorsn jorsn changed the title libextractor: 1.9 -> 1.10 libextractor: 1.9 -> 1.10, add me as maintainer Sep 18, 2020
@jorsn

This comment has been minimized.

Sign in to view
@jorsn
libextractor: 1.9 -> 1.11
abc2349 
* removed upstreamed patches
* enabled installCheckPhase (they work, now!)
* bumped version
* updated license (gpl2+ -> gpl3+): according to the libextractor docs,
  it was licensed under gpl3+ since version 0.7!
* added myself as maintainer
@jorsn jorsn changed the title libextractor: 1.9 -> 1.10, add me as maintainer libextractor: 1.9 -> 1.11, add me as maintainer Feb 9, 2021
@jorsn
Copy link
Member Author

jorsn commented Feb 9, 2021

I did the following:

  1. solved the merge conflict due to 9bb3fcc and 66e4442
  2. incorporated all requests by @SuperSandro2000
  3. Bumped it to the new (2020-01-30) version 1.11, which fixes compatibility with new exiv2
  4. everything checked under Things done in the issue description

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 97142 run on x86_64-linux 1

1 package marked as broken and skipped:
  • vdrPlugins.xineliboutput
4 packages built:
  • doodle
  • gnunet
  • gnunet-gtk
  • libextractor

@SuperSandro2000 SuperSandro2000 merged commit 5535976 into NixOS:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@vrthra vrthra Awaiting requested review from vrthra

@viric viric Awaiting requested review from viric

@ck3d ck3d Awaiting requested review from ck3d

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jorsn @SuperSandro2000