Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pdoc3: init at 0.9.1 #97155

Merged
merged 1 commit into from Nov 22, 2020
Merged

pythonPackages.pdoc3: init at 0.9.1 #97155

merged 1 commit into from Nov 22, 2020

Conversation

catern
Copy link
Contributor

@catern catern commented Sep 4, 2020

Motivation for this change

pdoc3 is nicer than Sphinx.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@catern catern mentioned this pull request Sep 4, 2020
Open
jonringer
jonringer reviewed Sep 4, 2020
View reviewed changes
pkgs/development/python-modules/pdoc3/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pdoc3/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pdoc3/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pdoc3/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pdoc3/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@catern
Copy link
Contributor Author

catern commented Sep 4, 2020

Sorry, pushed an earlier version initially... corrected those issues.

@catern
Copy link
Contributor Author

catern commented Sep 18, 2020

@jonringer ping?

@catern
Copy link
Contributor Author

catern commented Oct 18, 2020

Rebased, no conflicts, this is ready to merge, @jonringer @FRidh

@catern
pythonPackages.pdoc3: init at 0.9.1
3e28aad 
Seems broken on 3.6, hence the disabled = pythonOlder "3.7".
@7c6f434c 7c6f434c merged commit 6b813c7 into NixOS:master Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@catern @jonringer @7c6f434c