avro-cpp: 1.8.2 -> 1.10.0 #97154
avro-cpp: 1.8.2 -> 1.10.0 #97154
Conversation
|
@ofborg eval |
| @@ -7090,6 +7090,12 @@ | |||
| githubId = 4477729; | |||
| name = "Sergey Mironov"; | |||
| }; | |||
| smunix = { | |||
There was a problem hiding this comment.
Please put this into a separate commit with the message maintainers: add smunix.
| @@ -1,14 +1,14 @@ | |||
| { stdenv, fetchurl, cmake, boost, python2}: | |||
| { stdenv, fetchurl, cmake, boost, python2 }: | |||
There was a problem hiding this comment.
Can python2 be replaced?
|
@ofborg eval |
| maintainers = with stdenv.lib.maintainers; [ rasendubi smunix ]; | ||
| platforms = stdenv.lib.platforms.all; |
There was a problem hiding this comment.
| maintainers = with stdenv.lib.maintainers; [ rasendubi smunix ]; | |
| platforms = stdenv.lib.platforms.all; | |
| maintainers = with lib.maintainers; [ rasendubi smunix ]; | |
| platforms = lib.platforms.all; |
| @@ -28,7 +28,7 @@ stdenv.mkDerivation { | |||
| description = "A C++ library which implements parts of the Avro Specification"; | |||
| homepage = "https://avro.apache.org/"; | |||
| license = stdenv.lib.licenses.asl20; | |||
There was a problem hiding this comment.
| license = stdenv.lib.licenses.asl20; | |
| license = lib.licenses.asl20; |
There was a problem hiding this comment.
This won't eval as lib is not in scope.
There was a problem hiding this comment.
Then please add lib to inputs. This is a recent contributing guide change and stdenv.lib is deprecated.
|
I know this has been waiting for a review way too long… sorry about that. @smunix, do you still want to be co-maintainer of avro-cpp? I think the only critical comment is to separate If you don't have the motivation, I understand and can do the package update for you. |
Sure, let's hop to
Was busy with other projects too, I'll fix the package update this week. |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
Motivation for this change
Upgrade to the latest version of avro-cpp, 1.10.0
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)